Trie stats, query params, and better usage docs #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added some comments on how to use the tool, specifically regarding what format the trie files should be in.
Closed
|
@Nashtare Not sure how this happened, but a bunch of my changes for query params somehow didn't get into the PR. Added them now, and it should be a quick review. |
Nashtare
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the longest time,
trie_statswas living in it's own branch because the changes that it needed upstream was not merged into acrates.ioversion. Now that a version is published that has these fixes, we can mergetrie_statsintomain.The logic for trie queries has always supported different ways to configure the trie output, but it was never accessible by the user. This PR adds prog args that set these.
Also added docs on what format the tries are expected to be in. I really wanted to avoid duplicating this doc
5times across three binaries, so I ended up settling for usingafter_aboutto reuse a long shared common piece of help info. Note that I didn't really want to place this above a single argument since 2/3 of the binaries use this argument twice, which would add a lot of noise to the help page. Ideally, it would be nice to document an argument type and not just an argument, but I don't see this feature at all inclap.